✨ Add management column for application dependencies table #1541
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
=======================================
Coverage 40.46% 40.46%
=======================================
Files 145 145
Lines 4636 4636
Branches 1088 1088
=======================================
Hits 1876 1876
Misses 2746 2746
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| const labelValue = getParsedLabel(label).labelValue; | ||
| return labelValue === "java"; | ||
| }); | ||
| const isJavaFile = dependency.name.endsWith(".jar"); |
There was a problem hiding this comment.
-
Probably better to use
appDependency.dependency.namejust to keep the sourced data in the same place for the function. Or move the function and the TD render to a column render helper. Those helpers can be in the same file. That's what I'm doing in 🐛 Render dependency versions as links #1540. -
I don't see any dependency names ending with ".jar". All the names I see are
mavenGroupId.mavenArtifactId. I assume theappDependency.dependency.providerstring is supposed to be the language, but I've only seen empty string values for my analyses.
There was a problem hiding this comment.
@sjd78
@pranavgaikwad mentioned that we only see ".jar" deps when we are using a binary file as the input.
There was a problem hiding this comment.
Oh that is an interesting distinction.
So only "java" things where sources are not available will have a name with a .jar suffix.
There was a problem hiding this comment.
Updated the PR to include the render function helper. As far as checking available sources, not sure that I have a grasp on how we should go about considering that for the management column.
= Add management column for application dependencies table Signed-off-by: ibolton336 <[email protected]> PR updates Signed-off-by: ibolton336 <[email protected]> Add optional chaining for empty labels Signed-off-by: ibolton336 <[email protected]> filter out language labels Signed-off-by: ibolton336 <[email protected]>
Missing column "Management" in the Dependencies side drawer #1339
Depends on konveyor/tackle2-addon-analyzer#62